Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite calls to handleFadeTo #11

Merged
merged 2 commits into from
Nov 30, 2016
Merged

Fix infinite calls to handleFadeTo #11

merged 2 commits into from
Nov 30, 2016

Conversation

frranck
Copy link
Contributor

@frranck frranck commented Nov 30, 2016

to avoid infinite calls to handleFadeTo when calling twice fadeOut.

@frranck
Fix infinite calls to handleFadeTo
08de348 
to avoid infinite calls to handleFadeTo when calling twice fadeOut.
tbaranes
tbaranes requested changes Nov 30, 2016
View reviewed changes
Copy link
Owner

@tbaranes tbaranes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Can you add an entry to the CHANGELOG?

Otherwise, 👍

@tbaranes
Copy link
Owner

Will merge once travis is done

@tbaranes
Copy link
Owner

Travis seems out, I'm gonna merge anyway and prepare the next release. Thanks again!

@tbaranes tbaranes merged commit 13654a3 into tbaranes:master Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbaranes tbaranes tbaranes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frranck @tbaranes