Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Ignore Javacript Files" prevent the given scripts from loading #96

Closed
FaySmash opened this issue Apr 10, 2020 · 3 comments
Closed

"Ignore Javacript Files" prevent the given scripts from loading #96

FaySmash opened this issue Apr 10, 2020 · 3 comments
Milestone
V2.8.0

Comments

@FaySmash
Copy link

It seems that the "Ignore Javacript Files" and "Remove Javacript Files" do the same and prevent the given scripts from loading.

Before:
before

Settings:
settings

After:
after
@tbela99 tbela99 added this to the V2.8.0 milestone Apr 11, 2020
@tbela99
Copy link
Owner

tbela99 commented May 3, 2020

I cannot reproduce that issue

image

image

Feel free to reopen this issue if I missed something

@tbela99 tbela99 closed this as completed May 3, 2020
@FaySmash
Copy link
Author

FaySmash commented May 4, 2020

I added those two lines inside "Ignore Javascript Files" on my test instance you can play around with:

/media/jdbuilder/js/jdb.min.js
jdb.min.js

The first line has no affect at all, the second line produces the Bug described in the OP an removes the Script completely.

@tbela99 tbela99 reopened this May 10, 2020
tbela99 added a commit that referenced this issue May 10, 2020
@tbela99
ignored javascript are removed from the page #96
ac8b1d5
@tbela99
Copy link
Owner

tbela99 commented May 10, 2020

Fixed.

Thank you

@tbela99 tbela99 closed this as completed May 10, 2020
tbela99 added a commit that referenced this issue May 16, 2020
@tbela99
Merge pull request #90 from tbela99/v.next
fc698c3 
V2.8.0

- Add \.ico as a supported PWA icon format #78
- Add purpose property to the PWA manifest options #78
- Add screenshots property to the PWA manifest options #78- remove duplicated path the file name #88
- change default pwa display to _standalone_ #78
- \[performance\] precompress cache files. If the client advertises compression support, then send the compressed file. Brotli support requires the brotli extension #89
- optionally preserve IE conditional comments #88
- remove the length restriction of the manifest short_name #78
- fix security and performance issues induced by links with _target=\_blank_ attribute #91
- asynchronously initialize the service worker using \<script defer\> #78
- Link preloading : preload only once #99
- \[bug\] fix invalid configuration path #94
- \[bug\] the minification produced invalid HTML when the HTML provided had missing space between attributes #88
- \[bug\] the protocol is removed in the HTML content instead of href|src attributes only
- \[bug\] fix an uncaught javascript error in the service worker js #78
- \[bug\] fix 404 error when Hotlink protection is ON and cache files is OFF #78i
- \[bug\] fix ignored javascript are removed from the page #96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V2.8.0
Development

No branches or pull requests
2 participants
@tbela99 @FaySmash