Skip to content

Commit

Permalink
roachtest: remove now-unnecessary hack
Browse files Browse the repository at this point in the history
Closes cockroachdb#27717.

Release note: None
  • Loading branch information
tbg committed Sep 20, 2018
1 parent b903a24 commit 081eddd
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions pkg/cmd/roachtest/upgrade.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,7 @@ func registerUpgrade(r *registry) {
c.Put(ctx, b, "./cockroach", c.Range(1, nodes))
// Force disable encryption.
// TODO(mberhault): allow it once oldVersion >= 2.1.
start := func() {
c.Start(ctx, c.Range(1, nodes), startArgsDontEncrypt)
}
start()
time.Sleep(5 * time.Second)

// TODO(tschottdorf): this is a hack similar to the one in the mixed version
// test. Remove it when we have a 2.0.x binary that has #27639 fixed.
c.Stop(ctx, c.Range(1, nodes))
start()
time.Sleep(5 * time.Second)
c.Start(ctx, c.Range(1, nodes), startArgsDontEncrypt)

const stageDuration = 30 * time.Second
const timeUntilStoreDead = 90 * time.Second
Expand Down Expand Up @@ -266,7 +256,7 @@ func registerUpgrade(r *registry) {
}
}

const oldVersion = "v2.0.0"
const oldVersion = "v2.0.5"
for _, n := range []int{5} {
r.Add(testSpec{
Name: fmt.Sprintf("upgrade/oldVersion=%s/nodes=%d", oldVersion, n),
Expand Down

0 comments on commit 081eddd

Please sign in to comment.