Skip to content

Commit

Permalink
storage: un-starve TestReplicateQueueDownReplicate
Browse files Browse the repository at this point in the history
Before this change,

> make test PKG=./pkg/storage/ TESTS=TestReplicateQueueDownReplicate
> TESTFLAGS='-count 10'

takes ~109s on my laptop. After this change, it takes ~18s.

This is in line with a test failure on CI which looked like the test
had just never managed to schedule the goroutines that matter in time
for things to wrap up.

Fixes cockroachdb#32256.

Release note: None
  • Loading branch information
tbg committed Dec 11, 2018
1 parent 1cd7dcf commit 62ab2cb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/storage/replicate_queue_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,8 @@ func TestReplicateQueueDownReplicate(t *testing.T) {
base.TestClusterArgs{
ReplicationMode: base.ReplicationAuto,
ServerArgs: base.TestServerArgs{
ScanMinIdleTime: time.Millisecond,
ScanMaxIdleTime: time.Millisecond,
ScanMinIdleTime: 10 * time.Millisecond,
ScanMaxIdleTime: 10 * time.Millisecond,
Knobs: base.TestingKnobs{
Store: &storage.StoreTestingKnobs{
// Prevent the merge queue from immediately discarding our splits.
Expand Down

0 comments on commit 62ab2cb

Please sign in to comment.