Skip to content

Commit

Permalink
storage: add comment to replicaGC with pending split
Browse files Browse the repository at this point in the history
Persists a recent finding I made experimenting with cockroachdb#32594.

Release note: None
  • Loading branch information
tbg committed Dec 11, 2018
1 parent 3351943 commit f4f2a61
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions pkg/storage/replica_gc_queue.go
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,14 @@ func (rgcq *replicaGCQueue) process(
// look it up by RangeID) to disable the mechanism in #31875 for it.
// We should be able to use prefetching unconditionally to have this
// desc ready whenever we need it.
//
// NB: there's solid evidence that this phenomenon can actually lead
// to a large spike in Raft snapshots early in the life of a cluster
// (in particular when combined with a restore operation) when the
// removed replica has many pending splits and thus incurs a Raft
// snapshot for *each* of them. This typically happens for the last
// range:
// [n1,replicaGC,s1,r33/1:/{Table/53/1/3…-Max}] removing replica [...]
log.Infof(ctx, "removing replica with pending split; will incur Raft snapshot for right hand side")
}

Expand Down

0 comments on commit f4f2a61

Please sign in to comment.