Skip to content

Commit

Permalink
kvserver: disable assertion 'finished proposal inserted'
Browse files Browse the repository at this point in the history
Touches cockroachdb#97605.

Epic: none
Release note: None
  • Loading branch information
tbg committed Feb 24, 2023
1 parent 1c49593 commit f95866d
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pkg/kv/kvserver/replica_proposal_buf.go
Original file line number Diff line number Diff line change
Expand Up @@ -1189,7 +1189,10 @@ func (rp *replicaProposer) registerProposalLocked(p *ProposalData) {
if p.createdAtTicks == 0 {
p.createdAtTicks = rp.mu.ticks
}
if buildutil.CrdbTestBuild && (p.ec.repl == nil || p.ec.g == nil) {
// TODO(tbg): this assertion fires. Figure out why. See:
// https://github.com/cockroachdb/cockroach/issues/97605
const enableAssertion = false
if enableAssertion && buildutil.CrdbTestBuild && (p.ec.repl == nil || p.ec.g == nil) {
log.Fatalf(rp.store.AnnotateCtx(context.Background()), "finished proposal inserted into map: %+v", p)
}
rp.mu.proposals[p.idKey] = p
Expand Down

0 comments on commit f95866d

Please sign in to comment.