Skip to content

Commit

Permalink
Avoid unicode filename
Browse files Browse the repository at this point in the history
This is similar to 53e9d3e.

Over at https://github.com/cockroachdb/cockroach, we use bazel and it
chokes on this file:

```
java.io.IOException: Error extracting
[...]/com_github_maruel_panicparse_v2-v2.2.1.zip to [...]:
[...]/com_github_maruel_panicparse_v2/cmd/panic/internal/utf8/?tf8.go
(Illegal byte sequence)
```

which is why we're on a fork so far. It would be nice to avoid this.

There is an (eternal, it seems) [upstream discussion], so there is
little home of bazel starting to support non-unicode filenames.

I wonder if the loss in test coverage (if any) is acceptable in return
for avoiding build problems like the ones we've been seeing.

[upstream discussion]: bazelbuild/bazel#374
  • Loading branch information
tbg committed May 11, 2022
1 parent c579e89 commit 109e107
Showing 1 changed file with 0 additions and 0 deletions.
File renamed without changes.

0 comments on commit 109e107

Please sign in to comment.