Safe Limits API (#1325) #1355
Open
Safe Limits API (#1325) #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unaiur
force-pushed
the
safe-limits-v1
branch
2 times, most recently
from
282ea23
to
abe69b3
Compare
When an inverter has the safe limit timeout enabled, a new /api/limit/safe WebApi is enabled that allow to setup dynamic non-persistent limits. Those dynamic limits are reverted if they are not confirmed periodically before the safe limit timeout expires. This way, if the controller or the WiFi router dies, the limit is safely restored to the default limit.
unaiur
force-pushed
the
safe-limits-v1
branch
from
abe69b3
to
83319c2
Compare
|
This is a very good feature. Do you think it will get merged ? |
|
@unaiur maybe it would be a good idea to add this PR to OpenDTU-OnBattery as it would be more fitting there ? This is similar to a "hard" temporary limit, which will be used as a fallback after N minutes of idle time, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for feature request #1325.
When an inverter has a safe limit timeout enabled, a new /api/limit/safe endpoint is enabled to enact limits safely.
The caller needs to ensure that the limit is confirmed before the timeout expires; otherwise, the limit is rolled back to the safe limit value.