Inline default math type constructors #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I've been meaning to do this for a while. Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds
inlineto all the default math type constructors. This will allow the Haxe compiler to reduce allocations on local variables, which has huge performance implications for game projects that use lots of math functions every frame.As a test case, I used this branch on my physics library echo, which uses hxmath classes throughout its codebase. It nearly got rid of all my allocations, and drastically improved performance on Hashlink (over 2x!), which was previously getting hit pretty hard by garbage collection.
If you're interested, here is some more info on inlined constructors: https://haxe.org/manual/lf-inline-constructor.html