mxl58x improve rfsource to select any combination of modulator/inputs #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch we can use rfsource mxl58x module parameter to configure any arbitrary configuration of demods/inputs. We might want 7 demods to input 3 and 1 to input 2, or 5 to input 0, 2 to input 1 and 1 to input 2. All these setups can now be configured.
We use two bits to select input for each demod. demod 0 uses the two less significant bits and demod 7 the two most significant bits of a 16bit value.
Value of 1455 (binary 0000010110101111) is the same as default without using rfsource.
Example usage:
a. 0-6 demods to input 3, 7th demod to input 2
1011111111111111 => 49151
b. 0-4 demods to input 0, 5-6 demods to input 1, 7th demod to input 2
1001010000000000 => 37888
This has been tested in production and works well.
Only issue is that you can not reconfigure on the fly, you need to unload and reload modules with new value.