Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Add Promise.prototype.finally #1073

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Normative: Add Promise.prototype.finally #1073

merged 1 commit into from
Jan 24, 2018

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Jan 23, 2018

Add Promise.prototype.finally to ECMAScript.

Closes tc39/proposal-promise-finally#18.

@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. labels Jan 23, 2018
@ljharb ljharb mentioned this pull request Jan 23, 2018
Closed
25 tasks
mathiasbynens
mathiasbynens approved these changes Jan 24, 2018
View reviewed changes
Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@mathiasbynens
Copy link
Member

Test262 tests: https://github.com/tc39/test262/tree/master/test/built-ins/Promise/prototype/finally

@bterlson
Copy link
Member

LGTM as well.

@bterlson bterlson merged commit b1a633f into tc39:master Jan 24, 2018
ljharb added a commit to tc39/proposal-promise-finally that referenced this pull request Jan 24, 2018
@ljharb
Promise.prototype.finally is now stage 4!
1143ced 
tc39/proposals@4aa195c
tc39/ecma262#1073
Closes #18
@ljharb ljharb deleted the finally branch January 24, 2018 18:24
ljharb added a commit to airbnb/js-shims that referenced this pull request Jan 24, 2018
@ljharb
Promise.prototype.finally is at stage 4
ec6716d 
tc39/ecma262#1073
@anba anba mentioned this pull request Jan 26, 2018
Closed
evocateur pushed a commit to zillow/javascript that referenced this pull request Apr 10, 2018
@ljharb @evocateur
Promise.prototype.finally is at stage 4
8a91e51 
tc39/ecma262#1073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@bterlson bterlson Awaiting requested review from bterlson

@littledan littledan Awaiting requested review from littledan

Assignees

@bterlson bterlson

Labels
has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljharb @mathiasbynens @bterlson