Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Add Optional Chaining #1646

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Normative: Add Optional Chaining #1646

merged 1 commit into from
Dec 12, 2019

Conversation

DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Jul 25, 2019 •
edited
Loading

This change adds the relevant updates for the stage 3 Optional Chaining proposal. The intended changes can be viewed at https://tc39.es/proposal-optional-chaining/.

The Test262 PR is available at tc39/test262#2212

@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. labels Jul 25, 2019
@ljharb ljharb requested review from zenparsing, a team and waldemarhorwat July 25, 2019 18:32
@ljharb ljharb added the needs test262 tests The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262 label Jul 25, 2019
@ljharb ljharb requested a review from jridgewell July 25, 2019 18:32
@michaelblyons michaelblyons mentioned this pull request Jul 26, 2019
Closed
@claudepache claudepache mentioned this pull request Aug 8, 2019
Closed
@ljharb ljharb removed the request for review from zenparsing October 12, 2019 05:06
@pendenaor pendenaor mentioned this pull request Oct 29, 2019
Closed
@ljharb ljharb added has test262 tests and removed needs test262 tests The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262 labels Oct 31, 2019
bakkot
bakkot reviewed Nov 1, 2019
View reviewed changes
spec.html Outdated Show resolved Hide resolved
bakkot
bakkot reviewed Nov 1, 2019
View reviewed changes
spec.html Outdated Show resolved Hide resolved
bakkot
bakkot reviewed Nov 7, 2019
View reviewed changes
spec.html Show resolved Hide resolved
bakkot
bakkot reviewed Nov 7, 2019
View reviewed changes
spec.html Show resolved Hide resolved
@syg
Copy link
Contributor

syg commented Nov 12, 2019

Could someone update this PR to reflect the upstream fixes and editorial changes?

syg
syg reviewed Nov 13, 2019
View reviewed changes
spec.html Show resolved Hide resolved
@DanielRosenwasser
Copy link
Member Author

DanielRosenwasser commented Nov 13, 2019 •
edited
Loading

I've integrated the upstream changes and addressed feedback provided apart from the Evaluate_______PropertyAccess naming discussion which I'll try to address shortly.

bakkot
bakkot reviewed Nov 13, 2019
View reviewed changes
spec.html Show resolved Hide resolved
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 4, 2020
@jmdyck
Editorial: Add 4 <emu-prodref> elements to Annex A
6594c43 
(PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 4, 2020
@jmdyck
Editorial: tweak syntax in algorithms
4ed9628 
(PR tc39#1644 and PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 4, 2020
@jmdyck
Editorial: eliminate accidental ambiguity in Punctuator
6762395 
PR tc39#1646 introduced an ambiguity to the lexical grammar:
Punctuator derives OtherPunctuator in two different ways --
directly, and indirectly via OptionalChainingPunctuator.

It doesn't make sense for OptionalChainingPunctuator to derive OtherPunctuator,
so I've eliminated that alternative.
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 5, 2020
@jmdyck
Editorial: insert space before paren in clause heading
2466266 
(PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 5, 2020
@jmdyck
Editorial: eliminate grammatical parameters
7187282 
... from non-defining production.
(PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 5, 2020
@jmdyck
Editorial: Add 4 <emu-prodref> elements to Annex A
4a676f2 
(PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 5, 2020
@jmdyck
Editorial: tweak syntax in algorithms
0410ab2 
(PR tc39#1644 and PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 5, 2020
@jmdyck
Editorial: eliminate accidental ambiguity in Punctuator
f5e7449 
PR tc39#1646 introduced an ambiguity to the lexical grammar:
Punctuator derives OtherPunctuator in two different ways --
directly, and indirectly via OptionalChainingPunctuator.

It doesn't make sense for OptionalChainingPunctuator to derive OtherPunctuator,
so I've eliminated that alternative.
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 13, 2020
@jmdyck
Editorial: insert space before paren in clause heading
c72eb6b 
(PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 13, 2020
@jmdyck
Editorial: eliminate grammatical parameters
8022bdf 
... from non-defining production.
(PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 13, 2020
@jmdyck
Editorial: Add 4 <emu-prodref> elements to Annex A
5dda567 
(PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 13, 2020
@jmdyck
Editorial: tweak syntax in algorithms
1ceb114 
(PR tc39#1644 and PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 13, 2020
@jmdyck
Editorial: eliminate accidental ambiguity in Punctuator
5fb9b07 
PR tc39#1646 introduced an ambiguity to the lexical grammar:
Punctuator derives OtherPunctuator in two different ways --
directly, and indirectly via OptionalChainingPunctuator.

It doesn't make sense for OptionalChainingPunctuator to derive OtherPunctuator,
so I've eliminated that alternative.
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 13, 2020
@jmdyck
Editorial: insert space before paren in clause heading
b9db34c 
(PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 13, 2020
@jmdyck
Editorial: eliminate grammatical parameters
3e3bfae 
... from non-defining production.
(PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 13, 2020
@jmdyck
Editorial: Add 4 <emu-prodref> elements to Annex A
2cc4287 
(PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 13, 2020
@jmdyck
Editorial: tweak syntax in algorithms
f0e3cbf 
(PR tc39#1644 and PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 13, 2020
@jmdyck
Editorial: eliminate accidental ambiguity in Punctuator
9b44152 
PR tc39#1646 introduced an ambiguity to the lexical grammar:
Punctuator derives OtherPunctuator in two different ways --
directly, and indirectly via OptionalChainingPunctuator.

It doesn't make sense for OptionalChainingPunctuator to derive OtherPunctuator,
so I've eliminated that alternative.
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 15, 2020
@jmdyck
Editorial: insert space before paren in clause heading
d467a30 
(PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 15, 2020
@jmdyck
Editorial: eliminate grammatical parameters
8770b6d 
... from non-defining production.
(PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 15, 2020
@jmdyck
Editorial: Add 4 <emu-prodref> elements to Annex A
b05baba 
(PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 15, 2020
@jmdyck
Editorial: tweak syntax in algorithms
16620d1 
(PR tc39#1644 and PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 15, 2020
@jmdyck
Editorial: eliminate accidental ambiguity in Punctuator
456a22d 
PR tc39#1646 introduced an ambiguity to the lexical grammar:
Punctuator derives OtherPunctuator in two different ways --
directly, and indirectly via OptionalChainingPunctuator.

It doesn't make sense for OptionalChainingPunctuator to derive OtherPunctuator,
so I've eliminated that alternative.
ljharb pushed a commit to jmdyck/ecma262 that referenced this pull request Feb 19, 2020
@jmdyck @ljharb
Editorial: fixes from tc39#1646, tc39#1644, tc39#1406 (tc39#1787)
97d8f19 
 - insert space before paren in clause heading
 - eliminate grammatical parameters from non-defining production
 - Add 4 <emu-prodref> elements to Annex A
 - tweak syntax in algorithms
 - eliminate accidental ambiguity in Punctuator
      PR tc39#1646 introduced an ambiguity to the lexical grammar:
      Punctuator derives OtherPunctuator in two different ways --
      directly, and indirectly via OptionalChainingPunctuator.

      It doesn't make sense for OptionalChainingPunctuator to derive OtherPunctuator,
      so I've eliminated that alternative.
 - minor grammar refactoring re Punctuator
      Move the Punctuator production back to its former position.
      (Grammars are generally written top-down.)
 - Fix a 'use' production for AsyncConciseBody to match the new defining production
 - Add an <emu-prodref> for ExpressionBody to Annex A
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 20, 2020
@jmdyck
Editorial: Add 4 <emu-prodref> elements to Annex A
0c504b6 
(PR tc39#1646)
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request May 29, 2020
@jmdyck
Editorial: Delete more steps in the same vein as PR tc39#1519
e18d5bc 
(These steps come from PR tc39#1646, which went through its whole
life-cycle while tc39#1519 was dormant. Properly, after tc39#1646 was merged,
I should have rebased tc39#1519 and included these changes there.)
@bakkot bakkot mentioned this pull request May 29, 2020
Merged
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Jun 4, 2020
@jmdyck
Editorial: Delete more steps in the same vein as PR tc39#1519
6b54a09 
(These steps come from PR tc39#1646, which went through its whole
life-cycle while tc39#1519 was dormant. Properly, after tc39#1646 was merged,
I should have rebased tc39#1519 and included these changes there.)
ljharb pushed a commit to jmdyck/ecma262 that referenced this pull request Jun 15, 2020
@jmdyck @ljharb
Editorial: Delete more steps in the same vein as PR tc39#1519 (tc39#2022
2eb104a 
)

These steps come from PR tc39#1646, which went through its whole life-cycle while tc39#1519 was dormant. Properly, after tc39#1646 was merged, I should have rebased tc39#1519 and included these changes there.
@jmdyck jmdyck mentioned this pull request Jun 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenparsing zenparsing zenparsing left review comments

@devsnek devsnek devsnek left review comments

@jmdyck jmdyck jmdyck left review comments

@claudepache claudepache claudepache left review comments

@rkirsling rkirsling rkirsling approved these changes

@Wavez Wavez Wavez approved these changes

@bakkot bakkot bakkot approved these changes

@jridgewell jridgewell jridgewell approved these changes

@syg syg syg approved these changes

@ljharb ljharb ljharb approved these changes

@waldemarhorwat waldemarhorwat Awaiting requested review from waldemarhorwat

@michaelficarra michaelficarra Awaiting requested review from michaelficarra

Assignees

@ljharb ljharb

Labels
has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.