Normative: Fixed bug in NumberBitwiseOp #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
Confirmed against http://ecma-international.org/ecma-262/10.0/index.html#sec-binary-bitwise-operators-runtime-semantics-evaluation. Looks like it was probably a copy/paste mistake from the bitwise shift operator algorithm steps.
michaelficarra
added
editor call
ljharb
approved these changes
Apr 22, 2020
syg
approved these changes
Apr 22, 2020
ljharb
added
normative change
ljharb
force-pushed
the
bug-in-numberbitwiseop
branch
from
3471f70 to
c6fc823
Compare
ljharb
pushed a commit
that referenced
this pull request
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version ES2019, The Evaluation of binary bitwise operators utilize
ToInt32for both left and right expressions. However, the current version applyToInt32for only the left number value but useToUint32for the right number value inNumberBitwiseOp. I think it breaks the backward compatibility thus I revised the semantics ofNumberBitwiseOpto useToInt32for both left and right number values.