Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Replace non-ASCII quotes #2149

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

gibson042
Copy link
Contributor

The resolution of #1287 established a UTF-8 encoding of spec.html, but in practice the file contents are almost exclusively ASCII with the exception of 𝔽 and ℝ. This PR remedies the handful of outliers (a pair of β€œβ€¦β€ left/right quotes and some literal «…» guillemets), although I would not object to a subsequent sweep that replaces character references and/or "dumb" quotes.

@bakkot
Copy link
Contributor

bakkot commented Aug 20, 2020

I'm definitely in favor of getting rid of the smart quotes, but discussion on ecmarkup suggested that some people would prefer to use the actual codepoint rather than HTML entities for other non-ASCII characters like Β«.

@gibson042
Copy link
Contributor Author

Either way, it seems desirable to use the same patterns throughout the spec. This PR makes the minimum necessary changes to achieve that.

@ljharb
Copy link
Member

ljharb commented Aug 20, 2020

I'm fine temporarily using HTML entities for consistency, but I am not fine with using straight quotes in prose, which are always typographically incorrect. I used curly quotes in Annex E quite on purpose.

@gibson042
Copy link
Contributor Author

gibson042 commented Aug 20, 2020

I used curly quotes in Annex E quite on purpose.

Annex E contains no raw curly quotes; literally the only use of them is around "nullish" in the introduction. And there are several phrases wrapped in U+0022 QUOTATION MARK where curly quotes would be appropriateβ€”why should that one be special?

@gibson042
Copy link
Contributor Author

Oh, I misinterpreted your comment. Updating now.

@gibson042 gibson042 force-pushed the 2020-08-ascii-consistency branch from 3efd8bb to ede94de Compare August 21, 2020 15:19
Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy landing this now; if we decide later that we want to use the raw Unicode, we can convert everything at that point.

@ljharb ljharb requested review from michaelficarra, syg and a team August 23, 2020 20:41
@ljharb ljharb self-assigned this Aug 23, 2020
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is actually an improvement in any way (I don't care about short term consistency), but I'm fine with it and I look forward to the PR that reverses these.

 - For consistency, replace non-ASCII "curly quotes" with "&[lr]dquo;" character references
 - For consistency, replace non-ASCII guillemets with "&[lr]aquo;" character references
@ljharb ljharb force-pushed the 2020-08-ascii-consistency branch from ede94de to fb22c2b Compare August 27, 2020 23:06
@ljharb ljharb merged commit fb22c2b into tc39:master Aug 27, 2020
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants