-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Replace non-ASCII quotes #2149
Conversation
I'm definitely in favor of getting rid of the smart quotes, but discussion on ecmarkup suggested that some people would prefer to use the actual codepoint rather than HTML entities for other non-ASCII characters like |
Either way, it seems desirable to use the same patterns throughout the spec. This PR makes the minimum necessary changes to achieve that. |
I'm fine temporarily using HTML entities for consistency, but I am not fine with using straight quotes in prose, which are always typographically incorrect. I used curly quotes in Annex E quite on purpose. |
Annex E contains no raw curly quotes; literally the only use of them is around "nullish" in the introduction. And there are several phrases wrapped in U+0022 QUOTATION MARK where curly quotes would be appropriateβwhy should that one be special? |
Oh, I misinterpreted your comment. Updating now. |
3efd8bb
to
ede94de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy landing this now; if we decide later that we want to use the raw Unicode, we can convert everything at that point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is actually an improvement in any way (I don't care about short term consistency), but I'm fine with it and I look forward to the PR that reverses these.
- For consistency, replace non-ASCII "curly quotes" with "&[lr]dquo;" character references - For consistency, replace non-ASCII guillemets with "&[lr]aquo;" character references
ede94de
to
fb22c2b
Compare
The resolution of #1287 established a UTF-8 encoding of spec.html, but in practice the file contents are almost exclusively ASCII with the exception of
π½
andβ
. This PR remedies the handful of outliers (a pair ofββ¦β
left/right quotes and some literalΒ«β¦Β»
guillemets), although I would not object to a subsequent sweep that replaces character references and/or "dumb" quotes.