Editorial: Delete "the Number value for" in Number::leftShift #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
approved these changes
Jan 12, 2021
ljharb
approved these changes
Jan 12, 2021
michaelficarra
approved these changes
Jan 12, 2021
ljharb
added
the
ready to merge
ljharb
force-pushed
the
tweak_leftShift
branch
from
4ed91a1 to
190d474
Compare
|
(Wow, 49 minutes from submission to merge! Thanks.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with
Number::signedRightShiftandNumber::unsignedRightShift, the result of a left or right shift is a Number, so it doesn't make sense to get "the Number value for" that result.