Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: swap phrasing to indefinite article for Boolean-coercibles. #2295

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

DanielRosenwasser
Copy link
Member

In the definition for Array.prototype.find, we have

_predicate_ should be a function that accepts three arguments and returns a value that is coercible to a Boolean value.

In several other places like Array.prototype.findIndex, we have

_predicate_ should be a function that accepts three arguments and returns a value that is coercible to the Boolean value *true* or *false*.

While find is the odd-one-out, I think it uses cleaner language, and this PR makes other locations more consistent.

Alternatively, I can amend the definition of find.

@DanielRosenwasser DanielRosenwasser changed the title Editorial: swap phrasing to indefinite article for Boolean-coercibles." Editorial: swap phrasing to indefinite article for Boolean-coercibles. Feb 4, 2021
@ljharb ljharb requested review from michaelficarra, syg and a team February 4, 2021 04:39
@ljharb ljharb added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Feb 4, 2021
@ljharb ljharb merged commit d02d992 into tc39:master Feb 4, 2021
@DanielRosenwasser DanielRosenwasser deleted the toABooleanValue branch March 10, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants