Editorial: Align checks order in [[DefineOwnProperty]] overrides with ordinary method #2333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current spec, if an engine precisely implements
ValidateAndApplyPropertyDescriptor
and module namespace object's[[DefineOwnProperty]]
method, with descriptive error message for each failure, it would report different errors (given there is > 1 cause of failure) for the same(CurrentDescriptor, Descriptor)
pair when called on ordinary object vs module namespace object.Test case:
module.js:
index.js:
This change aligns descriptor validation order of TypedArray's and module namespace object's
[[DefineOwnProperty]]
methods withValidateAndApplyPropertyDescriptor
. For own non-configurable data descriptor, that is[[Configurable]] => [[Enumerable]] => IsAccessorDescriptor => [[Writable]] => [[Value]]
.The discrepancy this PR fixes is currently observable only in JSC.