Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: meta should be listed alongside target #2416

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Editorial: meta should be listed alongside target #2416

merged 1 commit into from
Jun 9, 2021

Conversation

himsngh
Copy link
Contributor

@himsngh himsngh commented May 26, 2021 •
edited by ljharb
Loading

Fixes #2298

nicolo-ribaudo
nicolo-ribaudo reviewed May 26, 2021
View reviewed changes
@himsngh himsngh requested a review from nicolo-ribaudo May 26, 2021 09:13
@ljharb ljharb changed the title editorial: #2298 meta should be listed alongside target Editorial: meta should be listed alongside target May 26, 2021
@ljharb ljharb requested review from michaelficarra, syg and a team May 31, 2021 21:19
michaelficarra
michaelficarra approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM. Any way we can avoid forgetting to modify this list in the future when we add more contextual keywords?

@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Jun 8, 2021
@ljharb ljharb merged commit 9f53106 into tc39:master Jun 9, 2021
mathiasbynens pushed a commit to mathiasbynens/ecma262 that referenced this pull request Oct 18, 2021
@himsngh @mathiasbynens
Editorial: meta should be listed alongside target (tc39#2416)
b4595d1 
Fixes tc39#2298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra michaelficarra approved these changes

@bakkot bakkot bakkot approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@syg syg Awaiting requested review from syg

Assignees
No one assigned
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

meta should be listed alongside target in 12.6.2
5 participants
@himsngh @michaelficarra @bakkot @nicolo-ribaudo @ljharb