Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Consistify miscellaneous phrases #2790

Merged
merged 5 commits into from
Aug 9, 2022

Conversation

h2oche
Copy link
Contributor

@h2oche h2oche commented Jun 2, 2022

I observed some phrases are written in inconsistent form:

  • To extract the element from the list of length 1, other phrases use the sole element of.
  • To check if the list is empty, other phrases use 'is empty' or 'is not empty'
  • To reference some well-known objects, other phrases use active function object and the running execution context, respectively.
  • To append an element to the end of list, other phrases use append _element_ to _list_.
  • Removed unnecessary prefix 'the String' for denoting a string literal.

@michaelficarra
Copy link
Member

The final commit here can be dropped in favour of #2711

Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. This is great!

@h2oche h2oche force-pushed the consistify-miscellaneous-phrases branch from fbfe5ac to 7e316a8 Compare June 8, 2022 06:29
@h2oche
Copy link
Contributor Author

h2oche commented Jun 8, 2022

@michaelficarra Oh, I see. I dropped it.

spec.html Outdated Show resolved Hide resolved
@bakkot
Copy link
Contributor

bakkot commented Aug 8, 2022

Looks good to me except for the three uses of "append" for updating a Set.

@michaelficarra michaelficarra force-pushed the consistify-miscellaneous-phrases branch from d38f8ea to 039b7e4 Compare August 9, 2022 01:45
@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Aug 9, 2022
@michaelficarra
Copy link
Member

@bakkot @h2oche I've gone ahead and just made the requested change. Should be ready to merge now.

@ljharb ljharb force-pushed the consistify-miscellaneous-phrases branch from 039b7e4 to 2df27d3 Compare August 9, 2022 04:55
@ljharb ljharb merged commit 2df27d3 into tc39:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial change establishes editorial conventions ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants