Editorial: GetValue and PutValue do not need to unwrap Completion Records #2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
force-pushed
the
get-value
branch
3 times, most recently
from
1b3cc55 to
3ddbd42
Compare
michaelficarra
approved these changes
Aug 3, 2022
jmdyck
reviewed
Aug 4, 2022
Done. In the process I marked initialization of |
michaelficarra
force-pushed
the
get-value
branch
from
2f9e98c to
5c5f020
Compare
michaelficarra
approved these changes
Aug 12, 2022
syg
approved these changes
Aug 17, 2022
spec.html
Outdated
| @@ -22038,7 +22032,7 @@ <h1> | |||
| 1. Set the running execution context's LexicalEnvironment to _newEnv_. | |||
| 1. Let _exprRef_ be Completion(Evaluation of _expr_). | |||
| 1. Set the running execution context's LexicalEnvironment to _oldEnv_. | |||
| 1. Let _exprValue_ be ? GetValue(_exprRef_). | |||
| 1. Let _exprValue_ be ? GetValue(? _exprRef_). | |||
There was a problem hiding this comment.
Out of curiosity did ecmarkup find this or was this manually audited?
There was a problem hiding this comment.
Manually, alas. ecmarkup does not yet track types except for checking the completion-ness of callsites of AOs, which is purely local.
ljharb
force-pushed
the
refactor-for-in-of
branch
from
5410f2e to
97e2321
Compare
bakkot
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2744 removed almost every case where GetValue or PutValue was passed a completion record, instead explicitly unwrapping on the previous line or lines. This removes the final three cases and then updates the definitions of those algorithms so that they do not need to handle being passed Completion Records.