Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: dfn the Pattern data structures #2880

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Editorial: dfn the Pattern data structures #2880

merged 1 commit into from
Sep 29, 2022

Conversation

michaelficarra
Copy link
Member

I also updated the Notation section's ID since it was way under-specific.

@michaelficarra michaelficarra requested a review from a team August 31, 2022 17:36
bakkot
bakkot reviewed Sep 5, 2022
View reviewed changes
spec.html Outdated Show resolved Hide resolved
@bakkot
Copy link
Contributor

bakkot commented Sep 5, 2022

cf #2486.

syg
syg reviewed Sep 21, 2022
View reviewed changes
Copy link
Contributor

@syg syg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the MatchState change. I have some concern over Range and Continuation being too generic English words to be dfn'd here. CaptureRange and MatcherContinuation maybe?

@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label Sep 22, 2022
@michaelficarra
Copy link
Member Author

@syg Renamed.

@syg syg added ready to merge Editors believe this PR needs no further reviews, and is ready to land. and removed editor call to be discussed in the next editor call labels Sep 28, 2022
@ljharb ljharb merged commit af53caa into main Sep 29, 2022
@ljharb ljharb deleted the dfn-charset branch September 29, 2022 05:26
@bakkot bakkot mentioned this pull request Nov 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakkot bakkot bakkot approved these changes

@syg syg syg approved these changes

Assignees
No one assigned
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelficarra @bakkot @syg @ljharb