-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Correct ExportEntry.[[LocalName]] description #3126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine. It would be nice to also explain "*default*"
here. Even nicer to replace it with a spec enum.
@bakkot I think in this position, it can be replaced, but it wouldn't totally eliminate the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. I'm betting this is a copy-paste error from the ImportEntry Record table.
@michaelficarra This is the only position which uses |
ExportEntry.[[LocalName]]
calls itself the name used in the importing module. I think this is meant to say exporting.https://tc39.es/ecma262/multipage/ecmascript-language-scripts-and-modules.html#table-exportentry-records
Some export declarations relay imports (which would make this the importing module), but not all. It's always the exporting module for every export.
I think this probably snuck in by analogy with the
ImportEntry.[[LocalName]]
description.https://tc39.es/ecma262/multipage/ecmascript-language-scripts-and-modules.html#table-importentry-record-fields
This patch changes "importing" to "exporting" in
ExportEntry.[[LocalName]]
.