Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: More tweaks to low-level Date AOs #3193

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Editorial: More tweaks to low-level Date AOs #3193

wants to merge 21 commits into from

Commits on Jul 11, 2024

  1. Editorial: Inline DaysInYear into InLeapYear

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    22119f4 View commit details
    Browse the repository at this point in the history

  2. Editorial: Rename msFromTime as MillisecFromTime 

    ... to follow that convention that an AO name starts with a capital letter.
    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    8fc556c View commit details
    Browse the repository at this point in the history

  3. to math: msPerFoo constants

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c8ba24a View commit details
    Browse the repository at this point in the history

  4. to math: Day (return value)

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    a057a15 View commit details
    Browse the repository at this point in the history

  5. to math: TimeWithinDay (return value)

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    bb1a1ce View commit details
    Browse the repository at this point in the history

  6. to math: DayFromYear (parameter + return value)

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    6374d53 View commit details
    Browse the repository at this point in the history

  7. to math: TimeFromYear (parameter)

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    98b079a View commit details
    Browse the repository at this point in the history

  8. to math: YearFromTime (return value)

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    daf7061 View commit details
    Browse the repository at this point in the history

  9. to math: DayWithinYear (return value)

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ebcecf7 View commit details
    Browse the repository at this point in the history

  10. to math: InLeapYear (return value)

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    4f6c274 View commit details
    Browse the repository at this point in the history

  11. to math: MonthFromTime (return value + internal aliases)

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    bcf70ac View commit details
    Browse the repository at this point in the history

  12. to math: DateFromTime (return value + internal aliases)

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    f244ea8 View commit details
    Browse the repository at this point in the history

  13. to math: WeekDay (return value)

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    8bd779a View commit details
    Browse the repository at this point in the history

  14. to math: HourFromTime (return value)

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    062572d View commit details
    Browse the repository at this point in the history

  15. to math: MinFromTime (return value)

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    6a438de View commit details
    Browse the repository at this point in the history

  16. to math: SecFromTime (return value)

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    07987df View commit details
    Browse the repository at this point in the history

  17. to math: MillisecFromTime (return value)

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    0de9f1a View commit details
    Browse the repository at this point in the history

  18. to math: "Names of days of the week" table

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c351bd4 View commit details
    Browse the repository at this point in the history

  19. to math: "Names of months of the year" table

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    36df3cc View commit details
    Browse the repository at this point in the history

  20. to math: MakeTime, MakeDay, DateString, TimeZoneString, Date.prototyp… 

    …e.toUTCString (some internals only)

Generally, this just delays invocations of overstruck-F.
In some cases, this causes some comparisons (but not arithmetic)
to shift from Number to mathematical.
    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    80fe050 View commit details
    Browse the repository at this point in the history

  21. fixup: fix description of MonthFromTime and WeekDay

    @jmdyck
    jmdyck committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    38864d6 View commit details
    Browse the repository at this point in the history