Editorial: GetModuleNamespace cannot return empty #3484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
Nov 20, 2024
bakkot
approved these changes
Dec 18, 2024
bakkot
added
the
ready to merge
ljharb
pushed a commit
to kimjg1119/ecma262
that referenced
this pull request
Dec 19, 2024
ljharb
force-pushed
the
get-module-namespace
branch
from
f12d9a2 to
1699a75
Compare
ljharb
force-pushed
the
get-module-namespace
branch
from
b3595ad to
6298ee1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetModuleNamespace seems to cannot return EMPTY. It is because step 3 handles the exception; ModuleNamespaceCreate from step 3.d only returns object.