Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markup: add an ID to the "property key" dfn #3501

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

michaelficarra
Copy link
Member

@michaelficarra michaelficarra commented Nov 27, 2024

Without this, we can't open the references pane to find all references. Matches behaviour for the derivative term "property name".

@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Dec 11, 2024
@bakkot
Copy link
Contributor

bakkot commented Dec 11, 2024

Commits which only touch markup we call Markup: rather than Editorial:. Otherwise LGTM.

@ljharb ljharb added markup things that change the spec rendering, but not the contents and removed editorial change labels Dec 11, 2024
@ljharb ljharb changed the title Editorial: add an ID to the "property key" dfn Markup: add an ID to the "property key" dfn Dec 11, 2024
@ljharb ljharb force-pushed the property-key-dfn-id branch from 111241a to 4b3dbbf Compare December 11, 2024 22:31
@ljharb ljharb merged commit 4b3dbbf into main Dec 11, 2024
9 checks passed
@ljharb ljharb deleted the property-key-dfn-id branch December 11, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
markup things that change the spec rendering, but not the contents ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants