Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegExp fixes #403

Closed
wants to merge 7 commits into from
Closed

RegExp fixes #403

wants to merge 7 commits into from

Conversation

anba
Copy link
Contributor

@anba anba commented Feb 23, 2016

A few additional fixes for annex-b regular expression patterns. And while I was at it, I've also fixed #379.

The re-definitions of ClassAtomNoDash and ClassAtomNoDashInRange should
have had their uses updated with the previous Annex B updates,
but only their definitions  were.
- Reorder production rules in AtomEscape and ClassEscape to reduce duplications
- And use the same order in the main spec for consistency
@bterlson bterlson closed this in 18eb8ee Apr 15, 2016
ljharb pushed a commit to jmdyck/ecma262 that referenced this pull request Dec 2, 2020
Specifically, change:
    AtomEscape[U, N] :: CharacterEscape[~U, ?N]
to:
    AtomEscape[U, N] :: CharacterEscape[?U, ?N]

This fixes a bug that PR tc39#403 introduced way back in 2016.

Resolves issue tc39#1672 (which see for some discussion).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wording RegExp DecimalEscape is unnecessarily complicated
1 participant