Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only allow standalone reserve solidus in Annex B regular expression when immediately followed by c #910

Merged
merged 1 commit into from
May 15, 2017
Merged

Only allow standalone reserve solidus in Annex B regular expression when immediately followed by c #910

merged 1 commit into from
May 15, 2017

Conversation

anba
Copy link
Contributor

@anba anba commented May 4, 2017

This makes it easier to disallow invalid \k escapes for https://tc39.github.io/proposal-regexp-named-groups/#annex-b-grammar and also disallows /\/ 😰 .

cc @littledan

@anba anba mentioned this pull request May 4, 2017
Merged
@littledan
Copy link
Member

Intuitively, I like this way of representing it much better, but I want to defer to others on really reviewing this fully since I've gotten is so wrong before. With this formulation, do you think the definition of \k in the named group specification works as is, or does it need other changes?

cc @schuay @hashseed

@anba
Copy link
Contributor Author

anba commented May 4, 2017

With this formulation, do you think the definition of \k in the named group specification works as is, or does it need other changes?

It now works as expected.

@bterlson
Copy link
Member

I like this formulation. @littledan shall I wait for others to review before pulling?

@littledan
Copy link
Member

If it looks good to you, I'm happy with this being merged. It's a nice bug fix.

@bterlson
Copy link
Member

I am probably less of a regexp expert than you are so your previous deference to experts gave me pause. But, I think I understand everything here so I'll merge.

@bterlson bterlson merged commit 421a6ae into tc39:master May 15, 2017
@bterlson
Copy link
Member

image

@mysticatea mysticatea mentioned this pull request Oct 5, 2018
Closed
mysticatea added a commit to mysticatea/regexpp that referenced this pull request Oct 5, 2018
@mysticatea
Fix: follow tc39/ecma262#910 (refs eslint/eslint#10861)
0dc0b65
@bakkot bakkot mentioned this pull request Nov 29, 2018
Merged
bluelovers added a commit to bluelovers/regexpp that referenced this pull request May 7, 2019
@bluelovers
Merge remote-tracking branch 'mysticatea/master'
c0e8186 
* mysticatea/master:
  2.0.1
  Fix: follow tc39/ecma262#910 (refs eslint/eslint#10861)
  2.0.0
  2.0.0-beta.0
  Update: Unicode version to 11
  Breaking: replace Disjunction node by Alternative node
  Docs: update README.md
  Chore: trivial
  Chore: follow up mysticatea#2
  Update: parseRegExpLiteral supports RegExp object
  Chore: coverage
  Chore: upgrade deps
  Fix: location of quantifier (fixes mysticatea#3)
  New: add visitor
  Chore: update eslint config
  Breaking: drop Node.js 4 support

# Conflicts:
#	.eslintignore
#	.eslintrc.yml
#	package.json
#	src/index.ts
#	src/parser.ts
#	test/fixtures/parser/literal.ts
#	tsconfig.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anba @littledan @bterlson