Add Unified Intl.NumberFormat proposal to ECMA-402. #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested review from
Ms2ger,
leobalter,
littledan,
caiolima and
spectranaut
spectranaut
requested changes
Feb 3, 2020
| Localized symbols for compact and scientific notation (<emu-xref href="#sec-formatnumber"></emu-xref>) | ||
| </li> | ||
| <li> | ||
| Localized <ins>narrow, short, and long</ins> currency symbols <del>and names</del> (<emu-xref href="#sec-formatnumber"></emu-xref>) |
Ms2ger
reviewed
Feb 4, 2020
| @@ -131,7 +131,8 @@ <h1>ResolvePlural ( _pluralRules_, _n_ )</h1> | |||
| 1. Return *"other"*. | |||
| 1. Let _locale_ be _pluralRules_.[[Locale]]. | |||
| 1. Let _type_ be _pluralRules_.[[Type]]. | |||
| 1. Let _s_ be ! FormatNumericToString(_pluralRules_, _n_). | |||
| 1. Let _res_ be ! FormatNumericToString(_pluralRules_, _n_). | |||
| 1. Let _s_ be _res_.[[FormattedString]] | |||
There was a problem hiding this comment.
Suggested change
| 1. Let _s_ be _res_.[[FormattedString]] | |
| 1. Let _s_ be _res_.[[FormattedString]]. |
Ms2ger
reviewed
Feb 4, 2020
| 1. Assert: _notation_ is *"compact"*. | ||
| 1. Let _compactDisplay_ be _numberFormat_.[[CompactDisplay]]. | ||
| 1. Let _compactPatterns_ be _notationSubPatterns_.[[compact]].[[>_compactDisplay_<]]. | ||
| 1. Return _compactPatterns_.[[_exponent_]]. |
There was a problem hiding this comment.
Suggested change
| 1. Return _compactPatterns_.[[_exponent_]]. | |
| 1. Return _compactPatterns_.[[<_exponent_>]]. |
|
TC39 approved this for Stage 4 today, February 5, 2019. I will address the comments here and then we should be in the clear to merge. |
leobalter
reviewed
Feb 26, 2020
leobalter
reviewed
Feb 27, 2020
| 1. Else if _exponent_ is not 0, then | ||
| 1. Assert: _notation_ is *"compact"*. | ||
| 1. Let _compactDisplay_ be _numberFormat_.[[CompactDisplay]]. | ||
| 1. Let _compactPatterns_ be _notationSubPatterns_.[[compact]].[[>_compactDisplay_<]]. |
There was a problem hiding this comment.
typo on the > and < ordering
leobalter
added a commit
to leobalter/ecma402
that referenced
this pull request
Feb 27, 2020
leobalter
added a commit
that referenced
this pull request
Feb 27, 2020
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to merge the Unified Intl.NumberFormat proposal into ECMA-402, pending final Stage 4 approval.
https://github.com/tc39/proposal-unified-intl-numberformat