Editorial: Improve PartitionDateTimeRangePattern #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Correctly use "set" vs. "let". * Separate loop conditions from table iteration. * Avoid adding new fields to existing Records.
…ateTimeRangePattern
ryzokuken
approved these changes
Apr 12, 2023
spec/datetimeformat.html
Outdated
| 1. Let _fieldName_ be the name given in the Range Pattern Field column of the row. | ||
| 1. If _rangePatterns_ has a field [[<_fieldName_>]], let _rp_ be _rangePatterns_.[[<_fieldName_>]]; else let _rp_ be *undefined*. | ||
| 1. If _rangePattern_ is not *undefined* and _rp_ is *undefined*, then | ||
| 1. Set _patternContainsLargerDateField_ to *true*. | ||
| 1. Else, | ||
| 1. Let _rangePattern_ be _rp_. | ||
| 1. If _dateFieldsPracticallyEqual_ is *true* and _patternContainsLargerDateField_ is *false*, then |
There was a problem hiding this comment.
It was a bit difficult to follow this change but now I'm confident the final result makes the flow simpler, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements noticed while reviewing #770