Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Allow use of non-ISO 4217 data in CurrencyDigits AO #922

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

ben-allen
Copy link
Contributor

This PR allows for locale data other than ISO 4217 for determining the number of fractional digits to be used when formatting currency values.

In some applications ISO 4217 is most appropriate, in some CLDR data, and in some neither is best. See #921 (comment)

Resolves #134

This PR makes the CurrencyDigits AO implementation-defined.

This PR allows for locale data other than ISO 4217 for determining
the number of fractional digits to be used when formatting currency
values.

In some applications ISO 4217 is most appropriate, in some CLDR data,
and in some neither is best. See tc39#921 (comment)

Resolves tc39#134

This PR makes the `CurrencyDigits` AO implementation-defined.
spec/numberformat.html Outdated Show resolved Hide resolved
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
@sffc
Copy link
Contributor

sffc commented Oct 3, 2024

TG2 approval: https://github.com/tc39/ecma402/blob/main/meetings/notes-2024-09-26.md#normative-allow-use-of-non-iso-4217-data-in-currencydigits-ao-922

@sffc said: "This PR looks good except I would like to have verification that CLDR does not actually try to match ISO 4217."

@sffc
Copy link
Contributor

sffc commented Oct 7, 2024

@sffc
Copy link
Contributor

sffc commented Oct 8, 2024

CLDR spec change: unicode-org/cldr#4112

@FrankYFTang
Copy link
Contributor

I believe this PR is discussed in TC39 2024-10-09 meeting and reach consensus

@ben-allen
Copy link
Contributor Author

Received consensus at October 2024 plenary, with guidance to make future editorial changes giving recommended data source

@ben-allen ben-allen merged commit 8c934de into tc39:main Oct 11, 2024
2 checks passed
@ben-allen ben-allen added needs tests has consensus (TG1) Has consensus from TC39-TG1 and removed needs consensus labels Oct 11, 2024
ben-allen added a commit to ben-allen/test262 that referenced this pull request Oct 29, 2024
treats ISO 4217 data on the number of minor unit digits to
use when formatting currencies. See tc39/ecma402#922
ben-allen added a commit to ben-allen/test262 that referenced this pull request Oct 29, 2024
…for currency minor unit digits

ISO 4217 no longer normative for currency minor digits. New test verifies that
currency data (from whatever source) is used by verifying that `maximumFractionDigits` and `minimumFractionDigits`
are identical. See tc39/ecma402#922
ptomato pushed a commit to ben-allen/test262 that referenced this pull request Oct 31, 2024
…for currency minor unit digits

ISO 4217 no longer normative for currency minor digits. New test verifies that
currency data (from whatever source) is used by verifying that `maximumFractionDigits` and `minimumFractionDigits`
are identical. See tc39/ecma402#922
ptomato pushed a commit to tc39/test262 that referenced this pull request Oct 31, 2024
ISO 4217 no longer normative for currency minor digits. New test verifies that
currency data (from whatever source) is used by verifying that `maximumFractionDigits` and `minimumFractionDigits`
are identical. See tc39/ecma402#922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has consensus (TG1) Has consensus from TC39-TG1 normative
Projects
Status: Other Issues
Development

Successfully merging this pull request may close these issues.

Permit CLDR rather than ISO 4217 for CurrencyDigits?
5 participants