use real source text for emu-grammar nodes in main document #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll look at that. Grammarkdown should be interpreting html entities as the character the entity represents. |
|
Ah, the issue in |
michaelficarra
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #266.
The issue was that #254 was inadvertently causing the rendering of
emu-grammarnodes in the main document to use the.innerHTMLrather than the real source, meaning it was passing[...] DecimalEscape [> but only [...]to grammarkdown. Grammarkdown then silently dropped it. (Which is surprising to me; I'd expect at least an error. cc @rbuckton.)This fixes the issue from #254 and also makes the fallback path robust against this.