dynamically add copyable step numbers #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
force-pushed
the
list-numbers-2
branch
from
cd4d5dc to
d2e5af1
Compare
ljharb
reviewed
Feb 12, 2021
michaelficarra
approved these changes
Feb 12, 2021
This was referenced Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to #289, this PR tries to repair the regular copy-paste functionality. From discussion with the other ecma262 editors, we generally prefer this route: in particular the usual case is that you want to copy exactly one line, by triple-clicking it, and this serves that use-case better and without any new UI elements.
I'd originally done this during the build rather than at runtime, but that turns out to make the rendered ecma262 spec 10% (600kb) larger. This seems better. It doesn't seem to noticeably affect time-to-interactive on the browsers I tested on.