Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-formatter #367

Merged
merged 2 commits into from
Nov 9, 2021
Merged

auto-formatter #367

merged 2 commits into from
Nov 9, 2021

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Nov 2, 2021

Fixes #317. You can see this applied to ecma262 at tc39/ecma262#2564.

Still needs docs.

This probably doesn't really need a comprehensive review. I'd just look at test/formatter.js to confirm that the things it's enforcing look correct.

@bakkot bakkot requested a review from michaelficarra November 2, 2021 06:28
@bakkot
Copy link
Contributor Author

bakkot commented Nov 2, 2021

Depends on tc39/ecmarkdown#89 getting landed/released, hence the CI failure. Edit: done.

package.json Outdated
@@ -48,7 +48,7 @@
"dependencies": {
"chalk": "^1.1.3",
"dedent-js": "^1.0.1",
"ecmarkdown": "../ecmarkdown/ecmarkdown-6.0.1.tgz",
"ecmarkdown": "6.0.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ecmarkdown": "6.0.2",
"ecmarkdown": "^6.0.2",

@bakkot bakkot merged commit 12b41ac into main Nov 9, 2021
@bakkot bakkot deleted the formatter branch November 9, 2021 02:30
@bakkot bakkot mentioned this pull request Nov 9, 2021
@bakkot bakkot mentioned this pull request Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

formatter
3 participants