Suppress line breaks before field/slot references #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
force-pushed
the
2024-08-pre-slot-line-breaks
branch
from
75a1497
to
e335060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an instance where a line break after the period in specAlias.[[SlotName]] made for confusing reading, making it look like a sentence was ending prematurely. This CSS change suppresses such line breaks by generating a non-copyable word joiner before each field/slot reference.
Before
Note the line break after "[[Block]] is buffer." and before the "[[ArrayBufferByteLengthData]]" that is connected to buffer:
After
Note the line break moving to after "[[Block]] is" and before "buffer.[[ArrayBufferByteLengthData]]", keeping the latter together as a single unit: