This repository was archived by the owner on Sep 8, 2021. It is now read-only.
Editorial: simplify early errors #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the early errors for ClassStaticInitializationBlock were not applied when nesting crossed "function or `static` initialization block boundaries." In the latter case (that is: nesting within a "static" initialization block), the rule applies recursively, triggering the early error despite the exception. Remove the exception to simplify the rule's definition.
|
I think this should no longer be an issue as of #46. Please take a look and let me know if that PR works instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the early errors for
ClassStaticInitializationBlock were not applied when nesting crossed
"function or
staticinitialization block boundaries." In the lattercase (that is: nesting within a "static" initialization block), the rule
applies recursively, triggering the early error despite the exception.
Remove the exception to simplify the rule's definition.