Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flesh out algorithms for addition, subtraction, multiplication, division, and remainder #143

Merged
merged 56 commits into from
May 30, 2024
Merged

Flesh out algorithms for addition, subtraction, multiplication, division, and remainder #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
a39e4db
Add `toFixed`, `toPrecision`, and `toExponential`
jessealama May 30, 2024
18865ce
Define AO to massage a potential Decimal128 value to an actual one
jessealama May 30, 2024
ffb818b
fixup: [spec] `npm run build`
jessealama May 30, 2024
0112bac
Say that Decimal128 values aren't ECMAScript language values
jessealama May 30, 2024
6492169
fixup: [spec] `npm run build`
jessealama May 30, 2024
2102502
Write to `index.html`
jessealama May 30, 2024
3cfc3b4
Use intrinsic
jessealama May 30, 2024
46908af
fixup: [spec] `npm run build`
jessealama May 30, 2024
aeb574f
Add dependencies for `index.html`
jessealama May 30, 2024
4793cd5
syntax
jessealama May 30, 2024
7aba909
Inline AO used only in the constructor
jessealama May 30, 2024
5dbb3c2
Fix references to undefined variables and mark an in-progres spot
jessealama May 30, 2024
0a52bec
Flesh out toString
jessealama May 30, 2024
0787942
fixup: [spec] `npm run build`
jessealama May 30, 2024
7b14446
Flesh out generation of exponential strings
jessealama May 30, 2024
e0862ff
fixup: [spec] `npm run build`
jessealama May 30, 2024
7c738c6
Flesh out `round` method
jessealama May 30, 2024
143e17a
Fix specification for exponent in `divide`
jessealama May 30, 2024
e031940
fixup: [spec] `npm run build`
jessealama May 30, 2024
8e5ec05
Fix intrinsic
jessealama May 30, 2024
fe53189
fixup: [spec] `npm run build`
jessealama May 30, 2024
9f4991a
Add checks for rounding mode
jessealama May 30, 2024
6d9609e
Fix argument name
jessealama May 30, 2024
37b1b43
fixup: [spec] `npm run build`
jessealama May 30, 2024
fc71450
Fix intrinsic
jessealama May 30, 2024
3b41658
fixup: [spec] `npm run build`
jessealama May 30, 2024
c2b9cd3
Flesh out `toFixed`
jessealama May 30, 2024
c3c2d3f
fixup: [spec] `npm run build`
jessealama May 30, 2024
767ce45
Flesh out `toPrecision`
jessealama May 30, 2024
d7bc702
fixup: [spec] `npm run build`
jessealama May 30, 2024
180a895
Pass in a Decimal128 rounding mode when massaging
jessealama May 30, 2024
c6fb6ac
fixup: [spec] `npm run build`
jessealama May 30, 2024
58504fc
Flesh out constructor
jessealama May 30, 2024
2ebf62d
Fix typo
jessealama May 30, 2024
d83e282
fixup: [spec] `npm run build`
jessealama May 30, 2024
f962809
Add references to IEE 754-2019
jessealama May 30, 2024
14c4990
Add brand checks
jessealama May 30, 2024
53d3528
Add section reference
jessealama May 30, 2024
98a03b9
typo
jessealama May 30, 2024
3dac59b
Add link
jessealama May 30, 2024
6e62cb1
fixup: [spec] `npm run build`
jessealama May 30, 2024
805e98f
Add reference for rounding
jessealama May 30, 2024
139a7d7
fixup: [spec] `npm run build`
jessealama May 30, 2024
2c9f14f
Add more IEEE 754 references
jessealama May 30, 2024
24e1304
syntax
jessealama May 30, 2024
896fd60
fixup: [spec] `npm run build`
jessealama May 30, 2024
ce4faca
Fix constant string usage
jessealama May 30, 2024
b553d1b
fixup: [spec] `npm run build`
jessealama May 30, 2024
8b4cb56
Use little e
jessealama May 30, 2024
327bef7
fixup: [spec] `npm run build`
jessealama May 30, 2024
d82e44c
Use "Otherwise"
jessealama May 30, 2024
7a0c301
fixup: [spec] `npm run build`
jessealama May 30, 2024
8e635e0
Add note about how we convert from Number
jessealama May 30, 2024
0494710
fixup: [spec] `npm run build`
jessealama May 30, 2024
b45d15b
Compress by using `Decimal128ValueToObject`
jessealama May 30, 2024
08391e1
fixup: [spec] `npm run build`
jessealama May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: ensure no line starts with tabs
- run: |
for f in *emu; do
if ! [ grep '^\t' "$f"]; then
if ! [ grep '^\t' "$f" ]; then
echo "$f has lines that begin with a tab";
exit 1;
fi
Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

all: index.html

index.html:
npx ecmarkup --lint-spec --strict --load-biblio @tc39/ecma262-biblio --load-biblio @tc39/ecma402-biblio spec.emu $<
index.html: spec.emu intl.emu
npx ecmarkup --lint-spec --strict --load-biblio @tc39/ecma262-biblio --load-biblio @tc39/ecma402-biblio spec.emu $@

clean:
rm -f index.html
Loading