Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues detected in October review from WH #180

Merged
merged 45 commits into from
Dec 11, 2024
Merged

Issues detected in October review from WH #180

merged 45 commits into from
Dec 11, 2024

Conversation

jessealama
Copy link
Collaborator

  • Make clear that all IEEE 754 Decimal128 values exist here.

@jessealama jessealama linked an issue Oct 8, 2024 that may be closed by this pull request
October spec review #179
Closed
26 tasks
@jessealama jessealama mentioned this pull request Oct 8, 2024
Closed
26 tasks
jessealama and others added 26 commits October 9, 2024 05:42
@jessealama
Fix missing italicization
d732b8f
@jessealama
fixup: [spec] npm run build
5ef2e04
@jessealama
Pick the longest string that does not end with trailing zeroes
174f778
@jessealama
fixup: [spec] npm run build
d684a16
@jessealama
Swap "smallest" for "largest"
e681121
@jessealama
fixup: [spec] npm run build
73486ee
@jessealama
Use identifier
71a7d54
@jessealama
fixup: [spec] npm run build
0b2abab
@jessealama
Swap "smallest" for "largest"
a7be619
@jessealama
fixup: [spec] npm run build
d1ef68c
@jessealama
Don't use truncated exponent
34dac6d
@jessealama
Refer to correct value
9a41a26
@jessealama
Use correct infinity
fb01416
@jessealama
Ensure use of decimal D
be77111
@jessealama
Remove spurious definition
db5789e
@jessealama
fixup: [spec] npm run build
de0e599
@jessealama
Return false when comparing a NaN to anything
a41a609
@jessealama
fixup: [spec] npm run build
9024515
@jessealama
Watch out for -infinity
181b3e4
@jessealama
fixup: [spec] npm run build
4e4c61f
@jessealama
Ensure we work with real numbers
4b8f9e0
@jessealama
fixup: [spec] npm run build
54ece86
@jessealama
Combine multiple scale10 cases
8441fd6
@jessealama
fixup: [spec] npm run build
64f0853
@jessealama
Use proper value (and use as identifer)
8be5d49
@jessealama
fixup: [spec] npm run build
603868c
@jessealama jessealama marked this pull request as ready for review December 11, 2024 15:52
@jessealama jessealama merged commit 1845aca into main Dec 11, 2024
@jessealama jessealama deleted the 179-october-spec-review branch December 11, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

October spec review
1 participant
@jessealama