Hide .then and always trigger evaluation on exports list lookup
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a sensible compromise given the constraints. |
nicolo-ribaudo
changed the title
.then and consistently trigger evaluation.then and consistently trigger evaluation on exports list lookup
This was referenced Nov 22, 2024
nicolo-ribaudo
force-pushed
the
hide-then-and-consistent-trigger
branch
from
4731481 to
ebb6ed4
Compare
nicolo-ribaudo
changed the title
.then and consistently trigger evaluation on exports list lookup.then and always trigger evaluation on exports list lookup
|
All the changes in this PR got consensus at the Dec 2024 TC39 meeting. |
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the problems outlined during last plenary, with the less bad approach (i.e. deferred namespace objects do not have a
.thenproperty, regardless of what the module exports, and so accessing it gives a known result without evaluating the module).There is still a pending change to distinguish namespaces that could trigger evaluation from those that cannot.
Closes #49, closes #55, closes #56