Support elision in extractor expression cover grammar #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A preview of this PR can be found at https://tc39.es/proposal-extractors/pr/29. |
|
is this a user-aware syntax change or is it just make things technically correct? |
|
This fixes the cover grammar to match the ExtractorAssignmentPattern grammar so that |
|
@waldemarhorwat does this sufficiently cover your concern about Elision missing from the cover grammar from #23? I've opted for option 2 in #23 (comment) for the time being, and can revise based on the outcome of the discards proposal. |
|
FYI, unless anyone has comments on this PR, I plan to merge it later this evening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the grammar to use a cover for Arguments that includes the Elision elements necessary to support ExtractorAssignmentPattern.
Fixes #23