-
Notifications
You must be signed in to change notification settings - Fork 10
editorial tweaks #13
Comments
These all seem like good suggestions for PRs to me. Would you be interested in writing them? |
@jmdyck I've updated things, can you double check that it is suitable for your comments? |
The main sentence now reads:
You can't say that a nonterminal symbol "is used as" an input element -- they're different kinds of things. I fixed this in my suggested wordings, but I guess I should have stated it explicitly. Also, "and" should be "or". Given that the later insertion says "(other than the start of a |Script| or |Module|)", it would probably help readers to use similar wording for this sentence, so I recommend the second of my original two suggestions:
The other changes look good. |
updated |
I've filed tc39/ecma262#2816 ; please post further review there. |
It should probably be more like:
or
The later sentence:
is no longer true. After "contexts", you could insert "(other than the start of a |Script| or |Module|)".
BTW, the bulk of this paragraph (everything after the first 2 sentences) would probably be easier to read as a bulleted list.
All the InputElement* productions start with
WhiteSpace | LineTerminator | Comment | CommonToken
, and then give the alternatives that are different. So you should probably move theHashbangComment
alternative to at least afterCommonToken
.Also, since it's only used at the start of a |Script| or |Module|, you could presumably drop the
RightBracePunctuator
alternative.There's also a list of the |InputElement*| nonterminals in The Lexical and RegExp Grammars that would need to be updated. (Might be better to change it to not enumerate the nonterminals, e.g. "starting from various goal symbols".)
The text was updated successfully, but these errors were encountered: