Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the permanent bidirectional stability of immutable ArrayBuffer contents #44

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

gibson042
Copy link
Collaborator

No description provided.

@gibson042 gibson042 requested a review from erights February 19, 2025 00:21
Copy link

The rendered spec for this PR is available at https://tc39.es/proposal-immutable-arraybuffer/pr/44.

spec.emu Outdated
@@ -416,7 +416,7 @@ contributors: Mark S. Miller, Richard Gibson
</h1>
<dl class="header">
<dt>description</dt>
<dd>It is used to create an immutable ArrayBuffer (i.e., an ArrayBuffer with a an [[ArrayBufferIsImmutable]] slot) with contents from _fromBlock_.</dd>
<dd>It is used to create an immutable ArrayBuffer (i.e., an ArrayBuffer with a an [[ArrayBufferIsImmutable]] slot) with contents from _fromBlock_. The contents of an immutable ArrayBuffer's Data Block are constrained to be permanently stable, and may not be modified by either ECMAScript code or by other activities that may take place inside an implementation or observable by it.</dd>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar?

Suggested change
<dd>It is used to create an immutable ArrayBuffer (i.e., an ArrayBuffer with a an [[ArrayBufferIsImmutable]] slot) with contents from _fromBlock_. The contents of an immutable ArrayBuffer's Data Block are constrained to be permanently stable, and may not be modified by either ECMAScript code or by other activities that may take place inside an implementation or observable by it.</dd>
<dd>It is used to create an immutable ArrayBuffer (i.e., an ArrayBuffer with a an [[ArrayBufferIsImmutable]] slot) with contents from _fromBlock_. The contents of an immutable ArrayBuffer's Data Block are constrained to be permanently stable, and may not be modified by either ECMAScript code or by other activities that may take place inside an implementation or be observable by it.</dd>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not that the contents must never be observably modified, specifically from the perspective of ecmascript code? in practice that would still mean the host can't modify the backing memory.

@bakkot
Copy link

bakkot commented Feb 19, 2025

This is strictly speaking normative. (I claimed otherwise earlier but was mistaken.)

@erights
Copy link
Collaborator

erights commented Feb 19, 2025

Given @bakkot 's later point, that the rest of the spec as a whole still does not imply immutability, and therefore that this change is normative, I'm removing the term "Editorial: " from the title.

@erights erights changed the title Editorial: Document the permanent bidirectional stability of immutable ArrayBuffer contents Document the permanent bidirectional stability of immutable ArrayBuffer contents Feb 19, 2025
@erights erights mentioned this pull request Feb 19, 2025
44 tasks
@gibson042 gibson042 merged commit 1063845 into tc39:main Feb 19, 2025
1 check passed
gibson042 added a commit that referenced this pull request Feb 20, 2025
@gibson042
Copy link
Collaborator Author

This merge was somehow lost, and has been restored as 83479c9.

@erights
Copy link
Collaborator

erights commented Feb 21, 2025

I might have lost it with late-night "git push --force" steps when, in retrospect, I was too tired to do such things. Sorry!

If you can, please check if I accidentally wiped out anything else. Thanks!

@gibson042
Copy link
Collaborator Author

All of the other PRs seem to still be in place, but direct pushes to main are harder to track. I did just open #45, which may or may not duplicate a prior addition.

@mhofman
Copy link
Member

mhofman commented Feb 25, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants