Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAG self security and privacy review #76

Merged
merged 2 commits into from
Jul 9, 2020
Merged

TAG self security and privacy review #76

merged 2 commits into from
Jul 9, 2020

Conversation

xtuc
Copy link
Member

@xtuc xtuc commented Jul 4, 2020

I quickly wrote this, would like early feedback or if you have anything special to add

ljharb
ljharb reviewed Jul 5, 2020
View reviewed changes
tag-security-and-privacy.md Outdated Show resolved Hide resolved
littledan
littledan reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@littledan littledan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good, suggested some wording changes inline.

tag-security-and-privacy.md Outdated Show resolved Hide resolved
tag-security-and-privacy.md Outdated Show resolved Hide resolved
tag-security-and-privacy.md Outdated Show resolved Hide resolved
tag-security-and-privacy.md Outdated Show resolved Hide resolved
tag-security-and-privacy.md Outdated Show resolved Hide resolved
@xtuc xtuc changed the title WIP: TAG self security and privacy review TAG self security and privacy review Jul 8, 2020
@xtuc xtuc marked this pull request as ready for review July 8, 2020 22:45
ljharb
ljharb approved these changes Jul 8, 2020
View reviewed changes
tag-security-and-privacy.md Outdated Show resolved Hide resolved
tag-security-and-privacy.md Outdated Show resolved Hide resolved
@xtuc @ljharb
Apply suggestions from code review
a96012b 
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@xtuc xtuc merged commit 0fc409a into master Jul 9, 2020
@xtuc xtuc deleted the sven/tag-sec-review branch July 9, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@littledan littledan littledan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xtuc @ljharb @littledan