Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale should be the first argument #32

Closed
sffc opened this issue Sep 7, 2023 · 3 comments · Fixed by #62
Closed

Locale should be the first argument #32

sffc opened this issue Sep 7, 2023 · 3 comments · Fixed by #62

Comments

@sffc
Copy link

sffc commented Sep 7, 2023

I saw a slide in the presentation where the message string was first, locale second. We should keep locale as the first argument.

@eemeli
Copy link
Member

eemeli commented Sep 8, 2023

Are you proposing that the arguments should be (locales, source, options) or (locales, options, source)?

My sense is that any which way we go we'll need to break with some precedent, and that (source, locales, options) is the least worst choice as it adds the new required argument first and keeps the optional locales+options arguments together, as they are currently.

The current order was arrived at after some discussion with @gibson042 early on in the proposal.

@sffc
Copy link
Author

sffc commented Sep 8, 2023

Probably (locales, source, options) since options should be last so that you don't have any trailing arguments after the options bag.

@FrankYFTang
Copy link
Contributor

I also agree with sffc. I think locales should be the first arg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants