Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use locales as first argument #62

Merged
merged 2 commits into from
May 6, 2024
Merged

Use locales as first argument #62

merged 2 commits into from
May 6, 2024

Conversation

eemeli
Copy link
Member

@eemeli eemeli commented May 6, 2024

Fixes #32

Switches the first two constructor arguments around, so they're (locales, source, options) rather than (source, locales, options).

@eemeli eemeli requested a review from ryzokuken May 6, 2024 06:33
ryzokuken
ryzokuken approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this design slightly better! Thanks both.

@eemeli eemeli merged commit 0756aca into main May 6, 2024
@eemeli eemeli deleted the locales-first branch May 6, 2024 10:38
@eemeli eemeli mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Locale should be the first argument
2 participants
@eemeli @ryzokuken