Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PluralRuleSelectRange prose could be more concrete #57

Closed
codehag opened this issue Jul 7, 2021 · 2 comments
Closed

PluralRuleSelectRange prose could be more concrete #57

codehag opened this issue Jul 7, 2021 · 2 comments

Comments

@codehag
Copy link

codehag commented Jul 7, 2021

The arguments are formatted a bit strangely -- it makes it seem like this is conditional on four arguments, not that the four arguments are required. In addition, we are not specifying the types here, as we do normally for AOs. We might want to make the prose more specific (it is a bit hand wavy right now). Finally, Doesn’t specify what it is returning.

A question from @ryzokuken: Why does PluralRulesSelectRange not have a ToParts?

@sffc
Copy link
Collaborator

sffc commented Jul 15, 2021

The text for PluralRuleSelectRange is almost fully based on the pre-existing abstract operation PluralRuleSelect. I agree that it is too vague. I filed tc39/ecma402#593 to clean up both PluralRuleSelect and PluralRuleSelectRange.

A question from @ryzokuken: Why does PluralRulesSelectRange not have a ToParts?

ToParts is only relevant for string formatting, not plural rule selection.

@sffc sffc closed this as completed Jul 15, 2021
@ryzokuken
Copy link
Member

ToParts is only relevant for string formatting, not plural rule selection.

Oops, yes. Thanks for answering this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants