Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more clear on valid return values for PluralRuleSelect #593

Closed
sffc opened this issue Jul 15, 2021 · 0 comments · Fixed by #594
Closed

Be more clear on valid return values for PluralRuleSelect #593

sffc opened this issue Jul 15, 2021 · 0 comments · Fixed by #594
Assignees
@gibson042
Labels
c: spec Component: spec editorial issues editorial Involves an editorial fix s: in progress Status: the issue has an active proposal
Milestone
ES 2022

Comments

@sffc
Copy link
Contributor

sffc commented Jul 15, 2021

Reported by @codehag in tc39/proposal-intl-numberformat-v3#57

The abstract operation PluralRuleSelect does not clearly specify the set of valid return values, and it's not clear what the four arguments signify. This should be cleaned up with an editorial PR against ECMA-402. The PluralRuleSelectRange abstract operation in NFv3 should also be adjusted.
@sffc sffc added editorial Involves an editorial fix c: spec Component: spec editorial issues s: help wanted Status: help wanted; needs proposal champion labels Jul 15, 2021
@sffc sffc added this to the ES 2022 milestone Jul 15, 2021
@sffc sffc mentioned this issue Jul 15, 2021
Closed
@gibson042 gibson042 self-assigned this Jul 15, 2021
gibson042 added a commit to gibson042/ecma402 that referenced this issue Jul 15, 2021
@gibson042
Editorial: Define a structured signature for PluralRuleSelect
94c3114 
Fixes tc39#593
@gibson042 gibson042 mentioned this issue Jul 15, 2021
Merged
@ryzokuken ryzokuken added s: in progress Status: the issue has an active proposal and removed s: help wanted Status: help wanted; needs proposal champion labels Jul 22, 2021
gibson042 added a commit to gibson042/ecma402 that referenced this issue Jul 23, 2021
@gibson042
Editorial: Define a structured signature for PluralRuleSelect
0624298 
Fixes tc39#593
gibson042 added a commit to gibson042/ecma402 that referenced this issue Jan 6, 2022
@gibson042
Merge branch 'master' into tc39gh-593-improve-PluralRuleSelect
7024f5f
gibson042 added a commit that referenced this issue Jan 6, 2022
@gibson042
Editorial: Define structured signatures for PluralRuleSelect and GetO…
06cfbb9 
…perands (#594)

Fixes #593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gibson042 gibson042

Labels
c: spec Component: spec editorial issues editorial Involves an editorial fix s: in progress Status: the issue has an active proposal
Projects
None yet
Milestone
ES 2022
Development

Successfully merging a pull request may close this issue.

Editorial: Define a structured signature for PluralRuleSelect gibson042/ecma402
3 participants
@sffc @gibson042 @ryzokuken