pass the mode directly as a single string option instead of 2 bools #26
Conversation
|
|
||
| <emu-clause id="sec-getoption" type="abstract operation"> | ||
| <h1> | ||
| GetOption ( |
There was a problem hiding this comment.
why not use GetOption for the mode option? it would handle the default in a single step.
There was a problem hiding this comment.
GetOption (taken from 402) coerces the value based on the third parameter. We have a normative convention to no longer do that.
There was a problem hiding this comment.
Sure, but that suggests we should enhance GetOption to skip coercing, since we'll be using GetOption in Temporal anyways.
There was a problem hiding this comment.
Yeah sure, but again, that's in 402, so not really this proposal's problem. We'll have to figure out how to handle that editorially when merging temporal, since its coercion behaviour is presumably not changing to match our new conventions.
There was a problem hiding this comment.
Fair, but its coercion behavior should definitely be changing to match our new conventions - it hasn't shipped on the web yet so there's no reason not to do so.
There was a problem hiding this comment.
You're going to have to bring that up with the temporal people, not me. Also, they're not the only users. GetOption, with its current coercing behaviour, is used pretty extensively throughout 402 today: https://tc39.es/ecma402/#sec-getoption
michaelficarra
force-pushed
the
string-mode
branch
from
e67dd9b
to
811b38a
Compare
No description provided.