Don't imply this return value for addModule method
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledan
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Yeah, let's land this change. The code sample there is just buggy, since addModule doesn't return the worker at all. See https://developer.mozilla.org/en-US/docs/Web/API/Worklet/addModule#return_value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By putting the
addModulecall on its own line in this example the code example implies less about how it works, leaving open possibilities for stuff like this in the reader's imagination: whatwg/html#6911 (comment)Please feel free to close this if it's too trite (since this proposal isn't about the inner workings of
addModule). Just making this suggestion because I'm excited about the ideas discussed in the previously-linked issue. Thanks!