[spec] add builtin matchers with proper semantics and location #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 8, 2022
Jack-Works
reviewed
Jul 8, 2022
Comment on lines
+1039
to
+1040
| <emu-clause id="sec-placeholder"><h1>Placeholder to ensure correct clause numbering</h1></emu-clause> |
There was a problem hiding this comment.
ecmarkup will warn about duplicated clause ids.
There was a problem hiding this comment.
yes, i'm aware, but until ecmarkup supports arbitrary numbering, this is the only technique i've found, and we'll just have to ignore the warnings. cc @bakkot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #262.
I will file issues for the open questions contained herein:
There's spec TODOs for me for:
I'm going to merge this ASAP; we can iterate later.