Update proposal to match new group consensus #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Aug 30, 2023
|
Do we have these patterns (relation patterns) in this PR from @rbuckton? when (x > 20 and < 40) ... |
Jack-Works
reviewed
Aug 31, 2023
gibson042
reviewed
Aug 31, 2023
No, they don't have champion consensus yet. |
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
…. Since many return failure as non-false anyway, it often won't be usable anyway.
ljharb
reviewed
Sep 3, 2023
|
Hi @tabatkins did you forget the when pattern: ...
if (expression): ...
default: ... |
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
|
The new spec (#295) is ready for review, I hope you can pick some ideas from it and update the README because more details are considered when writing the spec than just considering the normal cases. thanks! |
…ger have to special-case things like Infinity
… to their own subsection so I can define the strict array-like behavior.
…d pattern in the example. Remove the issue.
This was referenced Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS, DO NOT MERGE
Rewriting the proposal to be in line with https://gist.github.com/tabatkins/51f35f88d7eea61d9ecbe3e82da817a5, as agreed by the champion group.
Currently I've only got the matchers rewritten as a first pass; have not yet done the
match(){}expression or theisoperator.Closes #314.
Closes #313.
Closes #303.
Closes #301.
Closes #299.
Closes #297.
Closes #283.
Closes #282.
Closes #281.
Closes #264.
Closes #255.
Closes #253.